Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tether as bower dependency #18575

Merged
merged 1 commit into from
Jan 2, 2016
Merged

Add tether as bower dependency #18575

merged 1 commit into from
Jan 2, 2016

Conversation

QWp6t
Copy link
Contributor

@QWp6t QWp6t commented Dec 15, 2015

I know there was also talk of adding tether as a dependency in npm, but I figured I'd keep this PR limited to just bower so it's less likely to be met with resistance.

@cvrebert
Copy link
Collaborator

Fixes part of #17325.

@@ -29,6 +29,7 @@
"test-infra"
],
"dependencies": {
"jquery": "1.9.1 - 2"
"jquery": "1.9.1 - 2",
"tether": "1.1.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use ^ or ~

@QWp6t
Copy link
Contributor Author

QWp6t commented Dec 15, 2015

Done.

@cvrebert

@QWp6t
Copy link
Contributor Author

QWp6t commented Dec 20, 2015

👀

@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Jan 2, 2016
@cvrebert cvrebert added the js label Jan 2, 2016
cvrebert added a commit that referenced this pull request Jan 2, 2016
Add tether as bower dependency
@cvrebert cvrebert merged commit e93eeaa into twbs:v4-dev Jan 2, 2016
@cvrebert
Copy link
Collaborator

cvrebert commented Jan 2, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants